tests: improve coverage for P2tr and AddressType #683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeoComandini
force-pushed
the
2021-10-27-test-p2tr
branch
from
36a885e
to
11e979c
Compare
LeoComandini
force-pushed
the
2021-10-27-test-p2tr
branch
from
11e979c
to
8d5a8fd
Compare
|
utACK 8d5a8fd |
sanket1729
reviewed
Nov 15, 2021
src/util/address.rs
Outdated
| #[test] | ||
| fn test_p2tr() { | ||
| // stolen from https://github.com/bitcoin/bips/blob/master/bip-0086.mediawiki#Test_vectors | ||
| let key = hex_schnorr_key!("a60869f0dbcf1dc659c9cecbaf8050135ea9e8cdc487053f1dc6880949dc684c"); |
There was a problem hiding this comment.
This should be updated to take in the input internal key instead of the output key. We changed the since #691
There was a problem hiding this comment.
Rebased and removed test_p2tr since it was the same as p2tr_from_untweaked, added a couple of lines to the latter
The new AddressType test shows addresses that are valid but have no type. If in the future some of those get a type or become invalid (either voluntarily or due to a regression), this will highlight it.
LeoComandini
force-pushed
the
2021-10-27-test-p2tr
branch
from
8d5a8fd
to
0d463ec
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new AddressType test shows addresses that are valid but have
no type. If in the future some of those get a type or become
invalid (either voluntarily or due to a regression), this will
highlight it.