Improvements to script methods related to Taproot #721
Conversation
|
Concept ACK for the first commit. I think the second commit should be done cleanly after rust-secp256k1 release. |
| fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { | ||
| fmt::LowerHex::fmt(&self.0, f) | ||
| } | ||
| } |
There was a problem hiding this comment.
Any reason not to implement upper hex?
There was a problem hiding this comment.
It was absent since inner type does not implement it as well - and doing it should be a case of other PR. Here we just need to get the stuff needed for Taproot :)
|
@sanket1729 sorry it seemed I hd removed the second commit, but i had got its way through. Will remove once again this evening. |
|
@sanket1729 sorry it seemed I had removed the second commit, but i had got its way through. Will remove once again this evening. |
|
@sanket1729 second commit is removed |
dr-orlovsky
added
the
trivial
|
utACK 4b9b59f but needs rebase |
RCasatta
added
the
waiting for author
|
utACK, but needs rebase. |
|
Rebased. CI fails on fuzzing due to some network error unrelated to the PR. |
Kixunil
removed
the
waiting for author
| @@ -97,4 +96,11 @@ impl TweakedPublicKey { | |||
| &self.0 | |||
| } | |||
|
|
|||
| /// Serialize the key as a byte-encoded pair of values. In compressed form | |||
There was a problem hiding this comment.
nit: Would have liked to have a sentence about 32 byte xonly keys instead of compressed keys.
Extraction of a portion from #696 which can be done without changes in
rust-secp256k1