Change the parameter for control block verification #845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kixunil
previously approved these changes
Feb 25, 2022
|
FWIW looks good to me. |
Changes the API from TweakedPublicKey to XonlyPublicKey. I believe we introduced TweakedPublicKey to guard against creating address API. This is confusing because when we want to verify control block we have to call dangerous_assume_tweak. This is in true in most cases that the key would be tweaked, but we only want to guard in while creating a new address. If we want to verify blocks, we should deal with native X-only-keys regardless of how they were created
sanket1729
force-pushed
the
tweaked_pubkey_fixup
branch
from
af09900
to
91c5d71
Compare
Kixunil
approved these changes
Mar 3, 2022
Kixunil
added
one ack
apoelstra
approved these changes
Mar 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
introduced TweakedPublicKey to guard against creating address API. This
is confusing because when we want to verify control block we have to
call dangerous_assume_tweak.
want to guard in while creating a new address. If we want to verify
blocks, we should deal with native X-only-keys regardless of how they
were created