Fix multiplication for uint256 #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apoelstra
approved these changes
May 27, 2018
Tibo-lg
pushed a commit
to p2pderivatives/rust-bitcoin
that referenced
this pull request
Sep 1, 2020
Remove dependency on hex crate + bump to v0.9.0
Davidson-Souza
pushed a commit
to Davidson-Souza/rust-bitcoin
that referenced
this pull request
Jul 12, 2023
Fix cargo warning output and wrong pointer width Co-Authored-By: tomaka <pierre.krieger1708@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently I had some issues with multiplication method for
Uint256.Result of multiplication was always 0, and
mul_u32panicked sometimes.So I added some tests to detect those issues and fixed the problem.