Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Derive Eq for PSBT types #932

Merged
merged 1 commit into from Apr 1, 2022
Merged

Derive Eq for PSBT types #932

merged 1 commit into from Apr 1, 2022

Conversation

dr-orlovsky
Copy link
Collaborator

Closes #931

@dr-orlovsky dr-orlovsky added minor API Change This PR should get a minor version bump trivial Obvious, easy and quick to review (few lines or doc-only...) labels Apr 1, 2022
@dr-orlovsky dr-orlovsky added this to the 0.29.0 milestone Apr 1, 2022
@dr-orlovsky dr-orlovsky added this to In progress in PSBT via automation Apr 1, 2022
@dr-orlovsky dr-orlovsky added this to Ready for review in Derive unification Apr 1, 2022
@dr-orlovsky dr-orlovsky moved this from In progress to Review in progress in PSBT Apr 1, 2022
@dr-orlovsky dr-orlovsky mentioned this pull request Apr 1, 2022
Closed
apoelstra
apoelstra approved these changes Apr 1, 2022
View reviewed changes
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 603e75e

Derive unification automation moved this from Ready for review to Merge Ready Apr 1, 2022
sanket1729
sanket1729 approved these changes Apr 1, 2022
View reviewed changes
Copy link
Member

@sanket1729 sanket1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 603e75e.

PSBT automation moved this from Review in progress to Ready for merge Apr 1, 2022
@sanket1729
Copy link
Member

Any reason why this is 0.29.0? We can get it in, it has 2 ACKs and is a short PR.

@dr-orlovsky
Copy link
Collaborator Author

@sanket1729 because I was afraid of making you guys angree at me LOL :D Let's merge it!

@sanket1729
Copy link
Member

This is a simple/easy to review and useful change. I don't operate on some hard rules for what's allowed and what's not in RC, mostly subjective based on

  • Ease of review
  • Whether it is a bug
  • Necessity of feature
  • Timeline near release.

@sanket1729 sanket1729 merged commit cb4d34f into rust-bitcoin:master Apr 1, 2022
Derive unification automation moved this from Merge Ready to Done Apr 1, 2022
PSBT automation moved this from Ready for merge to Done Apr 1, 2022
@Kixunil Kixunil modified the milestones: 0.29.0, 0.28.0 Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apoelstra apoelstra apoelstra approved these changes

@sanket1729 sanket1729 sanket1729 approved these changes

Assignees
No one assigned
Labels
minor API Change This PR should get a minor version bump trivial Obvious, easy and quick to review (few lines or doc-only...)
Projects
Derive unification
Done
PSBT
Done
Milestone
0.28.0
Development

Successfully merging this pull request may close these issues.

PSBT lacking Eq implementation
4 participants
@dr-orlovsky @sanket1729 @apoelstra @Kixunil