Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix badges #970

Merged
merged 2 commits into from Apr 30, 2022
Merged

Fix badges #970

merged 2 commits into from Apr 30, 2022

Conversation

tcharding
Copy link
Member

@tcharding tcharding commented Apr 26, 2022

We have two small bugs in our README badges

  • Patch 1: sets the MSRV badge to the new 1.41.1
  • Patch 2: sets the license badge to the correct license, CC0

(To verify that the changes render correctly, click on the 'from' branch name above.)

Since we just bumped the MSRV, let's update the badge also.
Currently the readme badge is displaying Apache, we are not using the
Apache license, it should be CC0.

Use the correct CC0-1.0 Universal license.
Copy link
Member

@sanket1729 sanket1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK a0a83e1

@sanket1729 sanket1729 added the one ack PRs that have one ACK, so one more can progress them label Apr 27, 2022
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK a0a83e1

@apoelstra apoelstra merged commit 0dd2b43 into rust-bitcoin:master Apr 30, 2022
@tcharding tcharding deleted the badges branch May 1, 2022 23:54
ChallengeDev210 pushed a commit to ChallengeDev210/rust-bitcoin that referenced this pull request Aug 1, 2022
a0a83e1 README: Use correct license (Tobin C. Harding)
5c363bc README: Update badge to Rust 1.41.1 (Tobin C. Harding)

Pull request description:

  We have two small bugs in our README badges

  - Patch 1: sets the MSRV badge to the new 1.41.1
  - Patch 2: sets the license badge to the correct license, CC0

  (To verify that the changes render correctly, click on the 'from' branch name above.)

ACKs for top commit:
  sanket1729:
    ACK a0a83e1
  apoelstra:
    ACK a0a83e1

Tree-SHA512: e216cd36ac3ea477146c1a8ac842718dfe07762dd47378b7862a6ad5f92a08c25ed92133543fdc083d5edd80d08e7da46e1f87067c14d3240b3e411b2a05baf3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one ack PRs that have one ACK, so one more can progress them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants