Add CI by way of github actions #38
Conversation
|
I see in your repo https://github.com/tcharding/rust-bitcoinconsensus/actions/ there is a "Startup failure", could you fix to have a successful launch? |
tcharding
force-pushed
the
ci
branch
6 times, most recently
from
f1ad672
to
1b83c50
Compare
|
Thanks for looking at this @RCasatta, I got a subset of the actions to run. I'm do not understand why some repos in our stack test somethings and others don't so I just deleted the ones that I couldn't get to run. Of note, this PR contains |
|
The Cross test is testing a big-endian architecture, I think it's valuable to have and it precedently spotted endianness bugs. I think also embedded and 32-bit could be nice to have but could be added later I think. ACK 1b83c50 |
Would it be useful to unify CI pipelines for our whole stack (everything up to |
tcharding
force-pushed
the
ci
branch
5 times, most recently
from
a677fd7
to
775e788
Compare
|
I had a bit more of a go at this. Wrote an embedded test, but the C++ code in submodule fails to build. Reverting to draft until I work that out. Attempted to add 32 bit test back in too, no dice. |
|
Woops, wrong button. |
tcharding
force-pushed
the
ci
branch
3 times, most recently
from
26ecb58
to
366ea73
Compare
|
I got the 32 bit test to pass but I'm stumped on the embedded build failure? https://github.com/tcharding/rust-bitcoinconsensus/runs/4916913870?check_suite_focus=true |
tcharding
force-pushed
the
ci
branch
3 times, most recently
from
ff2276e
to
6314438
Compare
|
Taking this off draft, we can add the embedded test at a later stage. |
|
It's not clear to me the error in the embedded build... ACK 6314438 |
Phew! Glad its not just me :) |
There was a problem hiding this comment.
utACK 6314438. Thanks for this, any special reason not to include rust nightly? I believe we do those across rust-bitcoin repos
|
I plan to use rust-bitcoin-consensus soon to cross-test things easily. It is heavy work in rust-miniscript currently to draft transactions to send to the bitcoin core node to get verification. |
None at all, I just missed it. Will add, thanks. |
Currently we are using `appveyor` to run CI. GitHub actions is used in the rest of the repos in the `rust-bitcoin` organization. Using the same tools reduces the maintenance burden. Add CI by way of github actions, includes: - cargo test - carg doc - cargo test, 32 bit version - cargo test, big endian target
|
Merging this with the current stale acks, the force push only added nightly toolchain to the |
Currently we are using
appveyorto run CI. GitHub actions is used inthe rest of the repos in the
rust-bitcoinorganization. Using the sametools reduces the maintenance burden.
Please review carefully, I'm not a github actions expert by any means,
this patch is gleaned from other repos in the org.