Add a disabled rustfmt.toml #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do not currently use `rustfmt`, this is a nuisance for devs who routinely work on code bases that do use rustfmt who often have their editors set to format on save. We can make the life of such devs much better by explicitly disabling formatting using `rustfmt.toml`. ref: https://rust-lang.github.io/rustfmt/?version=v1.4.38&search=#disable_all_formatting
|
Merged without any ACKs. This is a non-code change. It has been open for 4 months, the same change has been merged right across the rust-bitcoin stack so is in no way controversial, the only reason for no acks that I can see is that either no one is looking or no one cares. This merge is a test to see if there is any negative feedback for merging strictly non-code changes with no acks. FTR I have attempted multiple times to drum up some reviews for this crate. |
|
post-merge ACK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do not currently use
rustfmt, this is a nuisance for devs who routinely work on code bases that do use rustfmt who often have their editors set to format on save. We can make the life of such devs much better by explicitly disabling formatting usingrustfmt.toml.ref: https://rust-lang.github.io/rustfmt/?version=v1.4.38&search=#disable_all_formatting