Implement std::error::Error for Error #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcharding
force-pushed
the
05-25-implement-error
branch
from
7f904b1
to
4079e10
Compare
apoelstra
approved these changes
May 25, 2022
|
On review before merging I realised this breaks no-std by adding a hard dependency on |
In order for the `bitcoinconsensus::Error` to be usable downstream we should implement `Display` and conditionally, if we are in a `std` environment, implement `std::error::Error`. - Add a `std` feature - Implement `core::fmt::Display` - Conditionally implement `std::error::Error`
tcharding
force-pushed
the
05-25-implement-error
branch
from
4079e10
to
814cd71
Compare
|
Force push contain newly added feature gating. Please re-review. |
|
I guess I need to figure out how to make submodules work, so that I can test this repo locally :/. Or maybe we could just convert to subtrees .... but maybe I'm opening a can of worms there. |
apoelstra
approved these changes
May 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that the usage of
bitcoinconsensus::Erroris more ergonomic for downstream users implementstd::error::Error.