Re-work the CI pipeline and test script #370
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `test.sh` has some code if guarded on an env var `DO_LINT` this variable is mis-named because the code only runs `cargo fmt` - this is not a linter, `clippy` is a linter. Re-name `DO_LINT` -> `DO_FMT` in the CI script and the CI workflow.
Currently the build output directory is hardcoded into the `test.sh` script, this means that for folks who use a different build output directory the test script fails to run the examples. We can overcome this by running the examples directly using `cargo`.
Use `set -e` to fail the script if any command fails. Add sanity calls to `cargo` and `rustc`.
To help keep the script executing in order of importance put the fuzzing stuff at the bottom near the benching stuff, this way all sanity checks will have been run.
In an effort to make CI more efficient add an if guard on env var `DO_FEATURE_MATRIX` that: - Runs tests for all features - Runs tests for each feature individually - Runs all the examples Add default sanity tests (build and test) that will always be run irrespective of env vars used when executing the script. This is similar to how we test in `rust-secp256k1`.
Re-work the CI work flow based on new changes to the `test.sh` stript. - Put `cargo fmt` in its own job (implies sanity tests also) - Run the feature matrix of tests in a separate job - Do bench marks in a separate job - Put fuzzing in a separate job - Do integration tests in a separate job
|
This more or less went in through different PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make an attempt at improving test coverage and improving the CI pipeline.
Leaving as draft until #374 gets sorted, it includes changes to the CI pipeline.