-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding substitution of pkh for taproot #589
Conversation
concept ACK. Though it took me quite a while to figure out what's going on. I think we should add a comment explaining that we're replacing I was also confused that pkh was still supported in Taproot, but I was just confused, I don't think we need to add any comments to clarify that. Finally, I don't know what the key origins table is that you're taking keys from -- I can't find it in BIP 174 or 370, at least not with the name "origin". So I'm unsure whether this is too magical...it may be that this causes certain workflows to work, but in such a way it'll stop working as soon as the set of PkHs and the key origin table stop being in sync, and this is such a nonobvious connection that it'd be a nightmare to debug. Unsure. |
54ad691
to
f7eb8cb
Compare
Signed-off-by: Harshil Jani <harshiljani2002@gmail.com>
f7eb8cb
to
c6bb142
Compare
We need to satisfy or dissatisfy the key and thus we need all the given key from a descriptor . edit : I have added more clear comment on this. |
@apoelstra, in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK c6bb142
Ah, that's right! Ok, with that in mind, I think it make sense to also use this set of keys to obtain public keys, since those are morally pretty similar to bip32 origins. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK c6bb142
Recently , We have introduced the method
substitute_raw_pkh
to deal with the change of pkh to expr_raw_pkh. This is the implementation of that method for the taproot miniscript.Reference PR : #557