Reduce visibility on secp-sys symbols #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheBlueMatt
force-pushed
the
2021-03-no-vis
branch
from
68c0e1e
to
0a3c776
Compare
real-or-random
previously approved these changes
Mar 19, 2021
|
@TheBlueMatt Can you rebase please? that will solve the CI failure |
cc-rs builds C dependencies with reduced visibility to avoid exporting the C symbols all the way out to any rust-built shared libraries however we override it with SECP256K1_API. We should avoid doing this, allowing LTO/DCE to do its work.
TheBlueMatt
force-pushed
the
2021-03-no-vis
branch
from
0a3c776
to
ee1103a
Compare
|
Rebased with no changes. |
|
Confirmed this doesn't break the way we use |
elichai
approved these changes
Jun 8, 2021
|
I'd prefer if there were a comment on the line, but I'm fine merging as-is. At the very least |
apoelstra
approved these changes
Jun 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc-rs builds C dependencies with reduced visibility to avoid
exporting the C symbols all the way out to any rust-built shared
libraries however we override it with SECP256K1_API. We should
avoid doing this, allowing LTO/DCE to do its work.
Note: THIS IS UNTESTED.#287 (comment)