New alloc feature #300
Merged
New alloc feature #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RCasatta
reviewed
May 17, 2021
src/lib.rs
Outdated
| #[cfg(feature = "alloc")] extern crate alloc; | ||
|
|
||
| #[cfg(all(feature = "std", feature = "alloc"))] | ||
| compile_error!("std and alloc are mutually exclusive"); |
There was a problem hiding this comment.
I've done the same in another PR rust-bitcoin/bitcoin_hashes#127
however, this causes an issue with how current resolver threat dependencies, taking the union of features if different crates specify different features. New resolver fixes this issue https://blog.rust-lang.org/2021/03/25/Rust-1.51.0.html#cargos-new-feature-resolver but it's much more modern than our MSRV
There was a problem hiding this comment.
so are you thinking that if they are both set, then we should act as if std only is set?
There was a problem hiding this comment.
added a fixup for this
TheBlueMatt
previously approved these changes
May 18, 2021
|
needs rebase |
Allows use of `Secp256k1::new` and related API if an allocator is available
|
rebased |
TheBlueMatt
approved these changes
Jun 8, 2021
real-or-random
approved these changes
Jun 9, 2021
elichai
approved these changes
Jun 9, 2021
|
Reminder that when our MSRV hits 1.36 we could simplify and remove a bunch of these cfg conditions and use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows use of
Secp256k1::newand related API, if an allocator is available