Add missing 'standard' derives for Parity type #362
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recently we (*cough* Tobin) added a new type `Parity` and neglected to add the standard derive attributes. By 'standard' I took to mean the ones typical in `rust-bitcoin` and mentioned in the upcoming `CONTIBUTING.md` document for that project.
Merged
|
Can you add a commit which bumps the minor version number? |
|
@apoelstra, @tcharding . This was already done in #361. But it might have been ignored because I did not have the proper title in PR description. It also adds serde related derives(required for rust-bitcoin downstream) and does the minor version bump too. |
|
@sanket1729 oh! Thanks. Yes, I did ignore the old title because it looked like the kind of thing that would take time to review :) |
|
(And in fact, I was wrong in reading the title ... I interpreted "wildcards" to mean something to do with miniscript keys, rather than rust imports ... so I shouldn't have expected it to be time-consuming.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently we (cough Tobin) added a new type
Parityand neglected to add the standard derive attributes. By 'standard' I took to mean the ones typical inrust-bitcoinand mentioned in the upcomingCONTIBUTING.mddocument for that project.