Use correct flag on big endian machines. #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will fix `tests::sign` test case on mips/mips64. Verified with
`cross`[1] tool.
cross test --target mips-unknown-linux-gnu
cross test --target mips64el-unknown-linux-gnuabi64
Unfortunately this fix doesn't make `tests::test_debug_output` test case
pass, but this is about debug output so its not as critical as this
patch. See rust-bitcoin#63 for a discussion.
[1]: https://github.com/japaric/rust-cross
|
Yeah, I'll change the |
Closed
This was referenced Sep 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix
tests::signtest case on mips/mips64. Verified withcross1 tool.Unfortunately this fix doesn't make
tests::test_debug_outputtest casepass, but this is about debug output so its not as critical as this
patch. See #63 for a discussion.