Add byte accessors to ElligatorSwiftSharedSecret
#676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kixunil
added
the
API hole
|
Can you run |
The inner bytes of `ElligatorSwiftSharedSecret` were almost inaccessible making the type almost useless, so this commit adds methods to access inner bytes. Closes rust-bitcoin#675
Kixunil
force-pushed
the
elligator-swift-secret-accessors
branch
from
396a739
to
7fe89c4
Compare
|
Given there are now two people who need it and it's a pretty significant missing piece (the hasher trick is horrible IMO) I think it's a strong argument for making an early point release. It looks like there weren't breaking changes since last release (I've only looked at commit titles). |
|
Agreed. I'll take a look and open a PR. Now that you are a maintainer here I don't need to do silly stuff like requesting you make the PR so I can ACK it :). |
apoelstra
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The inner bytes of
ElligatorSwiftSharedSecretwere almost inaccessible making the type almost useless, so this commit adds methods to access inner bytes.Closes #675