Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove wildcard re-exports #682

Merged
merged 7 commits into from
Mar 27, 2024

Commits on Mar 27, 2024

  1. Add a justfile

    The `just` command makes scripts and commands discoverable for new devs
    and old devs alike when switching between repos.
    
    Add a justfile copied from bitcoin with changes as required.
    tcharding committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    1e22d74 View commit details
    Browse the repository at this point in the history
  2. just: Add a command to check for API changes

    Add a command to run the `contrib/check-for-api-changes.sh` script.
    tcharding committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    c3f2c59 View commit details
    Browse the repository at this point in the history
  3. Update the API files

    Run `just check-api` and commit the changes. We should have never gotten
    to this state, upcoming patch will check for changes in CI.
    tcharding committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    53d34d5 View commit details
    Browse the repository at this point in the history
  4. CI: Check for API changes

    Add a job to run the `contrib/check-for-api-changes.sh` script in CI.
    tcharding committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    c61db1b View commit details
    Browse the repository at this point in the history
  5. Add script to update-lock-files

    Copy the script from `rust-bitcoin`, also add a `just` command to call
    it.
    tcharding committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    65d54e7 View commit details
    Browse the repository at this point in the history
  6. Remove wildcard re-exports of context types

    Wildcards make it hard to grep for where stuff comes from, explicit
    imports and re-exports are ... more explicit.
    
    Import and re-export explicitly instead of by using wildcards.
    tcharding committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    d63e95b View commit details
    Browse the repository at this point in the history
  7. Remove wildcard re-exports of key types

    Wildcards make it hard to grep for where stuff comes from, explicit
    imports and re-exports are ... more explicit.
    
    Re-export the `key` types explicitly.
    tcharding committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    0da394e View commit details
    Browse the repository at this point in the history