Check for API changes in CI #691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `just` command makes scripts and commands discoverable for new devs and old devs alike when switching between repos. Add a justfile copied from bitcoin with changes as required.
Add a command to run the `contrib/check-for-api-changes.sh` script.
Run `just check-api` and commit the changes. We should have never gotten to this state, upcoming patch will check for changes in CI.
Add a job to run the `contrib/check-for-api-changes.sh` script in CI.
Copy the script from `rust-bitcoin`, also add a `just` command to call it.
apoelstra
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is not just CI, it does a few clean up chores:
justfile(including command to check the API)