Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependency on libc #87

Merged
merged 1 commit into from
Dec 27, 2018
Merged

Remove dependency on libc #87

merged 1 commit into from
Dec 27, 2018

Conversation

tomaka
Copy link
Contributor

@tomaka tomaka commented Dec 27, 2018

The libc library doesn't compile for wasm32-unknown-unknown (see rust-lang/libc#831), so this PR removes the dependency on libc and makes it possible to compile for this target.

real-or-random
real-or-random approved these changes Dec 27, 2018
View reviewed changes
Copy link
Collaborator

@real-or-random real-or-random left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing dependencies is always a good idea and I personally prefer the std:: types anyway, so looks good to me if noone objects.

@TheBlueMatt TheBlueMatt merged commit 4f44a0f into rust-bitcoin:master Dec 27, 2018
@tomaka tomaka deleted the rm-libc branch December 27, 2018 17:23
@apoelstra
Copy link
Member

Nice!!

@elichai elichai mentioned this pull request Apr 19, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@real-or-random real-or-random real-or-random approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tomaka @apoelstra @real-or-random @TheBlueMatt