-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bindings for v0.18.0 and backport USDT support. #64
Add bindings for v0.18.0 and backport USDT support. #64
Conversation
Thanks for looking at this. I don't particularly object to regenerating previous versions where we can add USDT support. I don't think it would break anything that we're already exposing to do that. Adding support for 0.18.0 is definitely welcome though. |
Yeah, I can take a stab at regenerating older bindings where USDT support was present. (Note to self: based on cruising the Git tags for |
@brayniac I believe this is ready for a proper review now.
All tests pass, and looking at the regenerated bindings by hand seems like it's mostly just clean-up from the |
Thanks @tobz - yeah, for this crate I think we have to rely on the smoketest and then making sure it's all working with the bcc crate. It looks like I've forgotten to modify the smoketest to cover 0.16.0 and 0.17.0 - see https://github.com/rust-bpf/bcc-sys/blob/master/examples/smoketest.rs#L33 - it passed when I merged both of those, but now that they're not the latest versions... we're technically not testing that they didn't obviously break with this PR. If you don't mind fixing that up so we have proper test coverage for this PR that would be great. Otherwise this looks good. Thanks for spending time on the USDT support! |
Alright. smoke test adjusted, and things still look good. |
v0.18.0 is published to crates.io Thanks again! |
This PR is primarily centered around adding USDT support.
We've added bindings for v0.18.0 as I initially did so to test adding USDT support. Once that was sorted, per a comment on this PR, I went and backported USDT support all the way to v0.6.1 by generating new bindings.
Included in the PR, as well, is a simple shell script, suitable for use on Ubuntu, to make generating bindings a little more repeatable.
Closes #62