-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add USDT support. #171
Add USDT support. #171
Conversation
Thanks for working on this. Overall it looks pretty good. |
There's a few other things that clippy is pointing out in this PR. Would be good to address the ones in the new code (src/usdt/mod.rs) - I think I commented on the only new one in core, there's some existing code causing some clippy warnings which can be ignored for the sake of this PR. |
Very interested in this! Happy to take a look once it's ready for review! :) |
Went through and did a bunch of cleanup and various bits, namely....
I realize that the |
Thanks @tobz - this is looking pretty solid now. I'll do one more pass of review once CI is green. Appreciate the contribution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. Thanks for the contribution. I'll proceed to merge and generate a new release.
This PR adds USDT support, based on a transliteration of the Python implementation in
iovisor/bcc
.There's a lot of "icing" here as well: cleaning up styling, formatting, condensing code, etc.
Closes #167