Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds table crates #157

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wookietreiber
Copy link

To explain the differences between these crates: should this be done in this useful crates section, or should this be done in subsections? The pretty-table-printing authors have made an effort of explaining the differences in their respective crates, and a summary of that might very well be included here.


The spacing / empty newlines were just for my own sanity when looking at the actual document source. To me, it's much more readable with the additional whitespace.

@@ -23,9 +26,23 @@ There is always new crates being released that can be useful in the development
- [tokio](https://crates.io/crates/tokio) - asynchronous runtime
- [wasm-pack](https://crates.io/crates/wasm-pack) - tool for building WebAssembly


## Tables
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To explain the differences between these crates: should this be done in this useful crates section, or should this be done in subsections?

This should be a subsection of "Other crates" if we include it

Comment on lines +34 to +38
- [cli-table](https://crates.io/crates/cli-table)
- [comfy-table](https://crates.io/crates/comfy-table)
- [prettytable](https://crates.io/crates/prettytable-rs)
- [tabled](https://crates.io/crates/tabled)
- [term-table](https://crates.io/crates/term-table)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far, we only list out crates we directly use. We might want to give more thought to how we would want t talk about relevant crates more generally.

Can you open an issue for us to discuss this before merging this?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants