zig: do not overwrite bindgen env vars if already set #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #74 (comment)
basically,
BINDGEN_EXTRA_CLANG_ARGS_<target>was always set (i.e. overwritten) even if the env variable was already set by the user. this target-specific env variable also precedesBINDGEN_EXTRA_CLANG_ARGSwhich becomes powerless. as a result, users were not able to pass their own arguments to clang for bindgen through env variables.this fix checks if
BINDGEN_EXTRA_CLANG_ARGSorBINDGEN_EXTRA_CLANG_ARGS_<target>was already set. if it was set by the user, cargo-zigbuild will not overwrite those values and leave them as is.if both env vars are not set, cargo-zigbuild will keep its existing behavior by setting the clang sysroot.