Skip to content
This repository has been archived by the owner on Mar 1, 2019. It is now read-only.

link prefix components in paths #109

Closed
nrc opened this issue Oct 30, 2017 · 9 comments
Closed

link prefix components in paths #109

nrc opened this issue Oct 30, 2017 · 9 comments
Labels
p-high

Comments

@nrc
Copy link
Member

nrc commented Oct 30, 2017 •
edited
Loading

e.g., foo and bar in foo::bar::baz; currently we only have info for baz. This will require a name resolution fix in the compiler.
@nrc
Copy link
Member Author

nrc commented Oct 30, 2017

cc @Xanewok who was interested in implementing this and @jseyfried who probably knows how to do it.

@nrc nrc mentioned this issue Oct 30, 2017
Closed
@nrc nrc added the p-high label Nov 6, 2017
@nrc nrc mentioned this issue Jul 20, 2018
Closed
@doxxx doxxx mentioned this issue Jul 22, 2018
Open
@nrc nrc mentioned this issue Jul 24, 2018
Closed
@nrc nrc mentioned this issue Aug 15, 2018
Closed
@norru
Copy link

norru commented Aug 16, 2018

Is this project abandoned?

@nrc
Copy link
Member Author

nrc commented Aug 16, 2018

Is this project abandoned?

No, it is used in the RLS

This was referenced Sep 6, 2018
Closed
Merged
bors added a commit to rust-lang/rust that referenced this issue Oct 18, 2018
@bors
Auto merge of #54145 - nrc:save-path-segments, r=<try>
a7610b0 
Keep resolved defs in path prefixes and emit them in save-analysis

Closes rust-dev-tools/rls-analysis#109

r? @eddyb or @petrochenkov
bors added a commit to rust-lang/rust that referenced this issue Oct 22, 2018
@bors
Auto merge of #54145 - nrc:save-path-segments, r=<try>
2d61cfc 
Keep resolved defs in path prefixes and emit them in save-analysis

Closes rust-dev-tools/rls-analysis#109

r? @eddyb or @petrochenkov
bors added a commit to rust-lang/rust that referenced this issue Oct 26, 2018
@bors
Auto merge of #54145 - nrc:save-path-segments, r=petrochenkov
7b0735a 
Keep resolved defs in path prefixes and emit them in save-analysis

Closes rust-dev-tools/rls-analysis#109

r? @eddyb or @petrochenkov
@nrc nrc closed this as completed Oct 30, 2018
@pravic
Copy link

pravic commented Oct 31, 2018

If it works, it will be a huge step.

@norru
Copy link

norru commented Oct 31, 2018

Uhm, could this be related? rust-lang/rust#55480

@nrc
Copy link
Member Author

nrc commented Oct 31, 2018

Uhm, could this be related? rust-lang/rust#55480

doesn't look like it, but thanks for the heads up

@pravic
Copy link

pravic commented Oct 31, 2018

From rust-lang/rust#55521

This fixes the RLS tests, which are currently blocking distribution of the RLS.

So, we can't try the new resolution yet, correct?

@nrc
Copy link
Member Author

nrc commented Oct 31, 2018

So, we can't try the new resolution yet, correct?

Correct, we're waiting for 55521 to land and then a new nightly to come out. Hopefully tomorrow, maybe the next day.

@pravic
Copy link

pravic commented Nov 1, 2018

I see, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
p-high
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pravic @nrc @norru