WIP: Save path segments #53983
Closed
WIP: Save path segments #53983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @oli-obk (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
nrc
commented
Sep 6, 2018
| }); | ||
| source.name = crate_name; | ||
| span: source.0.span, | ||
| }, Some(ast::CRATE_NODE_ID))); |
There was a problem hiding this comment.
This should be a fresh node id, I think, but the id that is getting multiply resolved is not CRATE_NODE_ID
nrc
added
S-waiting-on-author
Do you have more details? Is that happening on the last segment? |
nrc
force-pushed
the
save-path-segments
branch
from
ca5cde0
to
deac165
Compare
|
I figured out what was going wrong - when resolving a nested import, we were using the same path prefix, rather than cloning, which was fine before, but now the segments would be resolved multiple times |
|
@nrc Ouch. If we don't hack around it, we could probably use it as a start of a redesign of how imports are resolved, to only resolve the prefix once, and then have the nested imports depend on the prefix import. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DON'T LAND
The idea with this PR is to save a def for every element of a path (we currently know this in name resolution but don't save it). Then we can save it in save-analysis and in an IDE we will be able to jump from the prefix segments of a path to their definition (which is a glaring omission in the RLS right now).
Obviously this is missing the save-analysis parts.
However, I am stuck because the compiler is panicking when bootstrapping std. I'm getting
path resolved multiple timesfrom here. From backtraces this is happening when resolving imports, (finalize_importis in the backtrace). However, it looks like that is only called once, fromresolve_crate, and I think that is the only time I would record the path segments (i.e., I wouldn't when callingresolve_importbecauserecord_usedisfalse).So, questions - am I doing anything stupid here which I shouldn't be doing at all or should be doing differently? Or do you know/can you see any way which we could be resolving the path segments more than once?
cc @petrochenkov @eddyb @jseyfried