Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update hardware.md #169

Merged
merged 4 commits into from
Feb 18, 2019
Merged

Update hardware.md #169

merged 4 commits into from
Feb 18, 2019

Conversation

flip111
Copy link
Contributor

@flip111 flip111 commented Feb 18, 2019

@flip111 flip111 requested a review from a team as a code owner February 18, 2019 20:27
@rust-highfive
Copy link

r? @therealprof

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-resources labels Feb 18, 2019
therealprof
therealprof reviewed Feb 18, 2019
View reviewed changes
src/intro/hardware.md Outdated

- There's a second USB port, labeled "USB USER" that is connected to the main microcontroller, the
STM32F303VCT6, and can be used in applications.
A word of warning: be careful if you want to apply external signals to the board. The microcontroller STM32F303VCT6 pins take a maximum voltage of 4 volts, but ideally should be driven by the nominal voltage of 3.3 volts. For further information consult the [6.2 Absolute maximum ratings section in the manual](https://www.st.com/resource/en/datasheet/stm32f303vc.pdf)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not mention "4V" (not even sure whether that's a typo or the maximum tolerable regular 3.3V) but instead say the nominal voltage is 3.3V with only a few pins being 5V tolerant.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with this.

therealprof
therealprof requested changes Feb 18, 2019
View reviewed changes
Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the nits that looks good to me.

src/intro/hardware.md Outdated

- 8 user LEDs arranged in the shape of a compass
- A second microcontroller: a [STM32F103CBT](https://www.st.com/en/microcontrollers/stm32f103cb.html). This microcontroller is actually part of an on-board programmer and debugger named ST-LINK and is connected to the USB port named "USB ST-LINK".
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While it is possible that there's a new DISC1 version of this board, in many cases the ST-Link/v2 is implemented via a STM32F103C8 MCU. I'd prefer to leave out the the part after the 103 to cater for both cases.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what you are getting at. Is there an alternative version of the same board? Shouldn't it have a different part number then?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what you are getting at. Is there an alternative version of the same board? Shouldn't it have a different part number then?

Yes. Typically the discoveries have a different part number but in this case there're just three revisions: "On-board ST-LINK/V2 for PCB version A or B or ST-LINK/V2-B for PCB version C and newer". Revision A and B have a STM32F103C8, revision C is a STM32F103CB.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about

This microcontroller is actually part of an on-board programmer / debugger and is connected to the USB port named "USB ST-LINK".

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean striking the previous sentence? Works for me.

@flip111 flip111 mentioned this pull request Feb 18, 2019
Closed
therealprof
therealprof reviewed Feb 18, 2019
View reviewed changes
src/intro/hardware.md Outdated

- 8 user LEDs arranged in the shape of a compass
- A second microcontroller: a [STM32F103CBT](https://www.st.com/en/microcontrollers/stm32f103cb.html). This microcontroller is actually part of an on-board programmer / debugger and is connected to the USB port named "USB ST-LINK".
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The STM32F103CBT reference is the one that required the fixing...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you try to edit my patch? is that enabled?

therealprof
therealprof reviewed Feb 18, 2019
View reviewed changes
src/intro/hardware.md Outdated Show resolved Hide resolved
@therealprof @flip111
Update src/intro/hardware.md
7014327 
Co-Authored-By: flip111 <flip101@gmail.com>
therealprof
therealprof approved these changes Feb 18, 2019
View reviewed changes
Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@therealprof
Copy link
Contributor

bors r+

bors bot added a commit that referenced this pull request Feb 18, 2019
@bors @flip111 @therealprof
Merge #169
9dc02c1 
169: Update hardware.md r=therealprof a=flip111

#140

Co-authored-by: flip111 <flip101@gmail.com>
Co-authored-by: Daniel Egger <daniel@eggers-club.de>
@bors
Copy link
Contributor

bors bot commented Feb 18, 2019

Build succeeded

@bors bors bot merged commit 7014327 into rust-embedded:master Feb 18, 2019
@ehuss ehuss mentioned this pull request Mar 5, 2019
Closed
bors added a commit to rust-lang/rust that referenced this pull request Mar 5, 2019
@bors
Auto merge of #58936 - ehuss:update-books, r=Centril
d977180 
Update books

Update nomicon, reference, book, edition-guide, embedded-book

rust-by-example cannot be updated because it is currently broken (rust-lang/rust-by-example#1161)

## nomicon

8 commits in b7eb4a087207af2405c0669fa577f8545b894c66..f1ff93b66844493a7b03101c7df66ac958c62418
2018-11-30 08:52:24 -0500 to 2019-02-26 13:37:28 -0500
- Fix typo in other-reprs.md (rust-lang/nomicon#112)
- Remove duplicate 'the' in aliasing.md (rust-lang/nomicon#116)
- Fix typo in subtyping.md (rust-lang/nomicon#117)
- Trivial updates to the coercions chapter (rust-lang/nomicon#118)
- Fix double "the" in aliasing.md (rust-lang/nomicon#119)
- Fixes outdated bindgen link (rust-lang/nomicon#110)
- Fix link to type layout reference (rust-lang/nomicon#121)
- Fix capitalization of Rust in races.md (rust-lang/nomicon#107)

## reference

18 commits in 1c775a1..41493ff
2019-01-13 21:12:05 +0100 to 2019-03-05 12:32:22 +0100
- Fix broken link. (rust-lang/reference#527)
- Update attribute documentation. (rust-lang/reference#528)
- Remove target_has_atomic. (rust-lang/reference#529)
- Remove "mode" from derive macro terminology. (rust-lang/reference#530)
- Clarifications (rust-lang/reference#493)
- Fix an incorrect note (rust-lang/reference#522)
- Document extern_crate_self (rust-lang/reference#517)
- Fix spelling (rust-lang/reference#520)
- Update conditional-compilation.md (rust-lang/reference#503)
- Document if_while_or_patterns (rust-lang/reference#516)
- Fix some broken links. (rust-lang/reference#519)
- Clarify what access struct updates do (rust-lang/reference#518)
- Document irrefutable_let_patterns (rust-lang/reference#515)
- Document Rc/Arc method receivers. (rust-lang/reference#494)
- unions have no active field (rust-lang/reference#478)
- attributes.md Outer -> Inner (rust-lang/reference#510)
- Let bindings are now available in const contexts (rust-lang/reference#512)
- Add missed literal at MacroFragSpec (rust-lang/reference#513)

## book

2 commits in fab9419503f0e34c1a06f9350a6705d0ce741dc6..9cffbeabec3bcec42d09432bfe7705125c848889
2019-02-25 07:53:23 -0500 to 2019-03-02 08:22:41 -0500
- More edits (rust-lang/book#1838)
- Remove the 2018 edition nostarch directory

## edition-guide

1 commits in 5f3cc2a5618700efcde3bc00799744f21fa9ad2e..aa0022c875907886cae8f3ef8e9ebf6e2a5e728d
2019-02-27 20:11:50 -0800 to 2019-02-27 22:10:39 -0800
- Fix one last link in readme. (rust-lang/edition-guide#153)

## embedded-book

12 commits in bd2778f304989ee52be8201504d6ec621dd60ca9..9e656ead82bfe869493dec82653a52e27fa6a05c
2019-02-10 12:37:14 +0000 to 2019-03-03 16:03:26 +0000
- Merge rust-embedded/book#174
- Merge rust-embedded/book#172
- Merge rust-embedded/book#169
- Merge rust-embedded/book#171
- Merge rust-embedded/book#168
- Merge rust-embedded/book#153
- Merge rust-embedded/book#142 rust-embedded/book#151
- Merge rust-embedded/book#133 rust-embedded/book#135
- Merge rust-embedded/book#150
- Merge rust-embedded/book#145
- Merge rust-embedded/book#129
- Merge rust-embedded/book#128
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@therealprof therealprof therealprof approved these changes

Assignees

@therealprof therealprof

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-resources
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@flip111 @rust-highfive @therealprof