Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document and test MSRV 1.38.0 #68

Merged
merged 3 commits into from Apr 23, 2020
Merged

Document and test MSRV 1.38.0 #68

merged 3 commits into from Apr 23, 2020

Conversation

teskje
Copy link
Contributor

@teskje teskje commented Apr 19, 2020

Part of wg/#445.

@teskje teskje requested a review from a team as a code owner April 19, 2020 12:08
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @reitermarkus (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@teskje
Bump MSRV to 1.33.0
66ffd9b 
On Windows the `backtrace` crate uses `#[cfg(target_vendor)]`, which was
unstable before 1.33.0.

This commit also changes the ordering of the Travis matrix entries to be
more readable.
@teskje teskje changed the title Document and test MSRV 1.32.0 Document and test MSRV 1.33.0 Apr 19, 2020
@teskje
Bump MSRV to 1.38.0
c6bf8d2 
On Windows, the backtrace crate requires at least Rust version 1.38.0.
rust-lang/backtrace-rs#276
@teskje teskje changed the title Document and test MSRV 1.33.0 Document and test MSRV 1.38.0 Apr 19, 2020
@teskje
Copy link
Contributor Author

teskje commented Apr 19, 2020

Okay, so the MSRV needs to be 1.38.0, solely because of the backtrace crate under Windows. Relevant issue: rust-lang/backtrace-rs#276

Under Linux and macOS everything works down to Rust 1.32.0.

@adamgreig adamgreig mentioned this pull request Apr 20, 2020
Closed
32 tasks
therealprof
therealprof approved these changes Apr 23, 2020
View reviewed changes
Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@therealprof
Copy link
Contributor

bors r+

@bors
Copy link
Contributor

bors bot commented Apr 23, 2020

Build succeeded:

@bors bors bot merged commit 6fa2b87 into rust-embedded:master Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@therealprof therealprof therealprof approved these changes

Assignees

@reitermarkus reitermarkus

Labels
S-waiting-on-review T-tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@teskje @rust-highfive @therealprof @reitermarkus