New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use of unstable pointer_cast feature #276
Comments
This function was stabilized in 1.38.0 which falls within the supported range of this crate. If you'd like to support previous versions of rustc PRs are welcome but I won't personally attempt further compatibility. |
This caused backtrace as a transitive dependency to break our builds. Adding newly-stabilized features or raising the minimum-required stable rust version of a crate seems like it should always be a major version bump. The only fix is likely to pull the release containing this code and re-release it with a major version bump. The supported stable versions of the head revision of this crate are irrelevant. Older rust versions were correctly supported by older versions of the crate and the issue is that the versioning appears to be incorrect. |
https://semver.org/#spec-item-4
|
Using
There is no consensus on this point and most crates in the ecosystem generally do not consider it a breaking change. See also: rust-lang/api-guidelines#123 @tobias-o In the Rust ecosystem, Cargo treats the leftmost non-zero digit in the version number as if it were the major version specified by semver. e.g., Crates going from |
Noted for future, we've been pretty ad-hoc with it.
This seems like it would be worth reconsidering. |
@BurntSushi Since Cargo's default behaviour for libs is to add a gitignore entry for Cargo.lock, I don't find that a very compelling suggestion. |
FWIW this is a pretty unproductive location to try to air concerns about Cargo, semver, etc. I'm going to mute this issue now because these sorts of discussions are rarely productive. I'll reiterate again. I'm sorry this caused breakage, but this update is within the policy of this crate for supported rustc versions, so I'm not going to personally take action. If anyone would like to send a PR I can merge it and publish a new version. |
On Windows, the backtrace crate requires at least Rust version 1.38.0. rust-lang/backtrace-rs#276
RtlLookupFunctionEntry(addr, &mut base, ptr::null_mut()).cast()
yields:Since this was added in a semver minor release, this breaks any CI for a Rust library crate that transitively depends on backtrace 0.3.
The text was updated successfully, but these errors were encountered: