Fix timing of asm-based delay implementation #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @therealprof (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
S-waiting-on-review
|
Build succeeded: |
Merged
bors bot
added a commit
that referenced
this pull request
Jan 25, 2021
320: Prepare for v0.7.1 r=therealprof a=adamgreig Includes: * Deprecate msp::write #297 * New syscall and bootstrap ASM #299 * More compiler fences #311 * asm::delay timing fix #312 * asm::delay clobber fix #317 * LTO for ASM fix #318 Doesn't include anything to help with #304 which might be nice to fix but can come in 0.7.2 and might need some time to think about. Co-authored-by: Adam Greig <adam@adamgreig.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #236
I've also moved the cycle adjustment into the assembly implementation, since it seems more appropriate there (and this will be useful if we make
cortex-m-asmits own crate).