Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate compiler fences around barrier instrs #311

Merged
merged 1 commit into from
Jan 7, 2021
Merged

Duplicate compiler fences around barrier instrs #311

merged 1 commit into from
Jan 7, 2021

Conversation

jonas-schievink
Copy link
Contributor

This should fix #308

@rust-highfive
Copy link

r? @therealprof

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-cortex-m labels Jan 7, 2021
adamgreig
adamgreig previously approved these changes Jan 7, 2021
Copy link
Member

@adamgreig adamgreig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@bors
Copy link
Contributor

bors bot commented Jan 7, 2021

👎 Rejected by too few approved reviews

Copy link
Member

@adamgreig adamgreig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@bors
Copy link
Contributor

bors bot commented Jan 7, 2021

Build succeeded:

@bors bors bot merged commit 1261653 into rust-embedded:master Jan 7, 2021
@jonas-schievink jonas-schievink deleted the more-fences branch January 7, 2021 17:48
@adamgreig adamgreig mentioned this pull request Jan 25, 2021
bors bot added a commit that referenced this pull request Jan 25, 2021
320: Prepare for v0.7.1 r=therealprof a=adamgreig

Includes:

* Deprecate msp::write #297
* New syscall and bootstrap ASM #299 
* More compiler fences #311 
* asm::delay timing fix #312 
* asm::delay clobber fix #317 
* LTO for ASM fix #318 

Doesn't include anything to help with #304 which might be nice to fix but can come in 0.7.2 and might need some time to think about.

Co-authored-by: Adam Greig <adam@adamgreig.com>
adamgreig pushed a commit that referenced this pull request Jan 12, 2022
311: Update changelog r=adamgreig a=jonas-schievink



Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-cortex-m
Projects
None yet
Development

Successfully merging this pull request may close these issues.

About those compiler_fence calls in the barrier functions.
4 participants