Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Android NDK version and API version #628

Closed
wants to merge 1 commit into from

Conversation

dalance
Copy link
Contributor

@dalance dalance commented Jan 18, 2022

This PR updates Android NDK version and API version as the same as libc crate.

https://github.com/rust-lang/libc/blob/master/ci/android-install-ndk.sh

Fix #195

@dalance dalance requested review from Dylan-DPC-zz and a team as code owners January 18, 2022 12:24
@dalance dalance closed this Jan 18, 2022
@Emilgardis
Copy link
Member

Why did you close this PR? I don't see anything wrong with it, and the CI failure is wide, see #609

@dalance
Copy link
Contributor Author

dalance commented Jan 19, 2022

I think CI failure is caused by the directory structure changing by NDK update.
I'll fix it, and reopen this PR.

@dalance
Copy link
Contributor Author

dalance commented Jan 19, 2022

I opened the new PR #629 because this PR can't be reopened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support same android ndk versions as rust-lang/rust and rust-lang/libc
3 participants