switch to GHCR and use more github actions #609

Emilgardis · 2021-11-18T20:58:56Z

addresses #607 #571

what this does

change default registry to look for cross images to ghcr.io
move from azure CI for docker images to GHA
add clippy (that does not fail job, can be made to do this later) and rustfmt
bump QEMU to 5.1
Add (better) layer caching

Some nice things to have/include

Cache docker images, possibly using buildx (probably out of scope of this pr)
Use actions/cache
make configuration easier to maintain
possibly replace docker setup with actions

.github/workflows/docker.yml

Emilgardis · 2021-11-18T21:13:06Z

bors try
🤞

Emilgardis · 2021-11-18T21:29:53Z

bors try

not sure what's up here

Emilgardis · 2021-11-18T21:34:18Z

.github/workflows/docker.yml

+        run: exit 0
+  docker-builds:
+    name: Docker Build
+    runs-on: ${{ matrix.image }}


this should work, but we're getting:

Docker Build : .github#L1 Error when evaluating 'runs-on' for job 'docker-builds'. .github/workflows/docker.yml (Line: 18, Col: 14): Unexpected value ''

matrix.image should be ubuntu-latest always, unless the include overrides it

https://github.com/rust-embedded/cross/actions/runs/1478440457

it doesn't work like I thought it did :D

Emilgardis · 2021-11-18T22:10:02Z

https://github.com/rust-embedded/cross/runs/4257575256?check_suite_focus=true

609: switch to GHCR and use more github actions r=reitermarkus a=Emilgardis addresses #607 #571 ## what this does - [x] change default registry to look for cross images to `ghcr.io` - [x] move from azure CI for docker images to GHA - [x] add clippy (that does not fail job, can be made to do this later) and rustfmt - [x] bump QEMU to 5.1 - [ ] Add (better) layer caching ## Some nice things to have/include - [x] Cache docker images, possibly using buildx (probably out of scope of this pr) - [x] Use actions/cache - [ ] make configuration easier to maintain - [ ] possibly replace docker setup with actions Co-authored-by: Emil Gardström <emil.gardstrom@gmail.com> Co-authored-by: Marco A L Barbosa <malbarbo@gmail.com> Co-authored-by: Jesse Szwedko <jesse@szwedko.me> Co-authored-by: Will <will@glozer.net> Co-authored-by: Sven-Hendrik Haase <svenstaro@gmail.com> Co-authored-by: Joe Richey <joerichey@google.com> Co-authored-by: Markus Reiter <me@reitermark.us>

bors · 2022-03-13T22:51:23Z

Build failed:

conclusion

reitermarkus · 2022-03-13T23:56:29Z

bors retry

bors · 2022-03-14T00:49:20Z

Build succeeded:

conclusion

646: don't push and load at the same time r=reitermarkus a=Emilgardis https://github.com/cross-rs/cross/actions/runs/1978039245 merge of #609 failed, this should fix that Co-authored-by: Emil Gardström <emil.gardstrom@gmail.com>

653: Add #609 to changelog. r=Emilgardis a=reitermarkus Co-authored-by: Markus Reiter <me@reitermark.us>

Fixes the solaris targets, and re-enables them in CI. Related to cross-rs#534 and cross-rs#609.

Uses a trick described in rust-lang/rust/issues#85821#issuecomment-969369677. Note that this still allows it to run, despite there seemingly being no entry point: this has no effect on the resulting code. Related to cross-rs#609. Partially fixes cross-rs#839.

840: Re-enable wasm32-unknown-emscripten target. r=Emilgardis a=Alexhuszagh Uses a trick described in rust-lang/rust/issues#85821#issuecomment-969369677. Note that this still allows it to run, despite there seemingly being no entry point: this has no effect on the resulting code. Related to #609. Partially fixes #839. Co-authored-by: Alex Huszagh <ahuszagh@gmail.com>

Fixes the solaris targets, and re-enables them in CI. Related to cross-rs#534 and cross-rs#609.

Uses a trick described in rust-lang/rust/issues#85821#issuecomment-969369677. Note that this still allows it to run, despite there seemingly being no entry point: this has no effect on the resulting code. Related to cross-rs#609. Partially fixes cross-rs#839.

See https://github.com/cross-rs/cross/wiki/Configuration#builddockerfile for context regarding the $CROSS_BASE_IMAGE environment variable. Here, it resolves to ghcr.io/cross-rs/armv7-unknown-linux-gnueabihf:{{cross_version}} Relies on docker caching instead of pre-building the image. Cross made the change to the GHCR on cross-rs/cross#609 Add newline at EOF for some files.

Emilgardis commented Nov 18, 2021

View reviewed changes

.github/workflows/docker.yml Outdated Show resolved Hide resolved

bors bot added a commit that referenced this pull request Nov 18, 2021

Try #609:

4e24e4e

Emilgardis force-pushed the ghcr_gha branch from dc39234 to e303849 Compare November 18, 2021 21:15

This comment has been minimized.

Sign in to view

bors bot added a commit that referenced this pull request Nov 18, 2021

Try #609:

ca927e5

This comment has been minimized.

Sign in to view

bors bot added a commit that referenced this pull request Nov 18, 2021

Try #609:

a28f5c5

Emilgardis commented Nov 18, 2021

View reviewed changes

This comment was marked as outdated.

Sign in to view

bors bot added a commit that referenced this pull request Nov 18, 2021

Try #609:

15d9909

cross-rs deleted a comment from bors bot Nov 18, 2021

This comment was marked as outdated.

Sign in to view

bors bot added a commit that referenced this pull request Nov 18, 2021

Try #609:

f4e98ed

This comment was marked as outdated.

Sign in to view

bors bot added a commit that referenced this pull request Nov 18, 2021

Try #609:

bc3f333

bors bot merged commit 5a0260b into cross-rs:main Mar 14, 2022

This was referenced Mar 14, 2022

don't push and load at the same time #646

Merged

freebsd: Include libdevstat in build image #620

Closed

Update FreeBSD quarterly package versions #636

Closed

reitermarkus mentioned this pull request Mar 14, 2022

Remove hard-coded old Qemu version for PPC targets. #586

Closed

reitermarkus added a commit that referenced this pull request Mar 16, 2022

Add #609 to changelog.

26df556

bors bot added a commit that referenced this pull request Mar 16, 2022

Merge #653

a9a3081

653: Add #609 to changelog. r=Emilgardis a=reitermarkus Co-authored-by: Markus Reiter <me@reitermark.us>

Emilgardis mentioned this pull request Mar 17, 2022

enable tests on windows and macos ci platform #610

Open

Emilgardis deleted the ghcr_gha branch April 6, 2022 09:20

Emilgardis mentioned this pull request Apr 23, 2022

Replace build-docker-image.sh with GHA actions #697

Open

Alexhuszagh mentioned this pull request May 27, 2022

Upgrade qemu to 5.1 #484

Closed

Emilgardis added this to the v0.2.2 milestone Jun 15, 2022

This was referenced Jun 16, 2022

add CROSS_CUSTOM_TOOLCHAIN to disable automatic target component downloading #803

Merged

Re-enable solaris targets. #838

Merged

Alexhuszagh added a commit to Alexhuszagh/cross that referenced this pull request Jun 22, 2022

Re-enable solaris targets.

c746b35

Fixes the solaris targets, and re-enables them in CI. Related to cross-rs#534 and cross-rs#609.

Alexhuszagh mentioned this pull request Jun 22, 2022

Re-enable wasm32-unknown-emscripten target. #840

Merged

Emilgardis pushed a commit to Emilgardis/cross that referenced this pull request Jun 24, 2022

Re-enable solaris targets.

88df58d

Fixes the solaris targets, and re-enables them in CI. Related to cross-rs#534 and cross-rs#609.

Alexhuszagh added the meta issues/PRs related to the maintenance of the crate. label Nov 6, 2022

LucasFA mentioned this pull request Mar 12, 2024

ci: Update docker images for arm RustAudio/cpal#865

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

switch to GHCR and use more github actions #609

switch to GHCR and use more github actions #609

Emilgardis commented Nov 18, 2021 •

edited

Loading

Emilgardis commented Nov 18, 2021

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Emilgardis commented Nov 18, 2021

Emilgardis Nov 18, 2021

Emilgardis Nov 18, 2021

Emilgardis Nov 18, 2021

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

Emilgardis commented Nov 18, 2021

This comment was marked as outdated.

bors bot commented Mar 13, 2022

reitermarkus commented Mar 13, 2022

bors bot commented Mar 14, 2022

switch to GHCR and use more github actions #609

switch to GHCR and use more github actions #609

Conversation

Emilgardis commented Nov 18, 2021 • edited Loading

what this does

Some nice things to have/include

Emilgardis commented Nov 18, 2021

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Emilgardis commented Nov 18, 2021

Emilgardis Nov 18, 2021

Choose a reason for hiding this comment

Emilgardis Nov 18, 2021

Choose a reason for hiding this comment

Emilgardis Nov 18, 2021

Choose a reason for hiding this comment

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

Emilgardis commented Nov 18, 2021

This comment was marked as outdated.

bors bot commented Mar 13, 2022

reitermarkus commented Mar 13, 2022

bors bot commented Mar 14, 2022

Emilgardis commented Nov 18, 2021 •

edited

Loading