Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port code snippets to the 2018 edition #102

Closed
japaric opened this issue Aug 2, 2018 · 2 comments · Fixed by #114
Closed

Port code snippets to the 2018 edition #102

japaric opened this issue Aug 2, 2018 · 2 comments · Fixed by #114
Assignees
@japaric
Labels
Blocks Rust 2018 help wanted
Milestone
2018

Comments

@japaric
Copy link
Member

japaric commented Aug 2, 2018

All the code snippets must be using 2018 edition features and must compile on 1.30-beta by RC1.
@japaric japaric added this to the RC1 milestone Aug 2, 2018
@johnthagen
Copy link
Contributor

@japaric For clarification, I assume this means both the in tree src (.rs files) as well as the examples scattered in the guide itself in Markdown code blocks?

@japaric
Copy link
Member Author

japaric commented Aug 7, 2018

Yes, I actually meant all the source code.

@japaric japaric self-assigned this Aug 7, 2018
@japaric japaric mentioned this issue Sep 15, 2018
Merged
bors bot added a commit that referenced this issue Sep 19, 2018
@bors @japaric
Merge #114
263dcfb 
114: 2018 edition r=therealprof a=japaric

This PR:

- moves the code to the 2018 edition and to cortex-m-rt v0.6.x
- simplifies setting up correct permissions (i.e. udev rules) for the st-link and the serial adapter 

closes #102 

r? @rust-embedded/resources (anyone)

Co-authored-by: Jorge Aparicio <jorge@japaric.io>
@bors bors bot closed this as completed in #114 Sep 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@japaric japaric

Labels
Blocks Rust 2018 help wanted
Projects
None yet
Milestone
2018
Development

Successfully merging a pull request may close this issue.

2018 edition rust-embedded/discovery
2 participants
@japaric @johnthagen