Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2018 edition #114

Merged
merged 4 commits into from
Sep 19, 2018
Merged

2018 edition #114

merged 4 commits into from
Sep 19, 2018

Conversation

japaric
Copy link
Member

@japaric japaric commented Sep 15, 2018

This PR:

  • moves the code to the 2018 edition and to cortex-m-rt v0.6.x
  • simplifies setting up correct permissions (i.e. udev rules) for the st-link and the serial adapter

closes #102

r? @rust-embedded/resources (anyone)

Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But it's so much stuff, maybe you want a second opinion.

@thejpster
Copy link

Likewise, what I looked at seemed OK, but there is a lot in this PR.

@japaric
Copy link
Member Author

japaric commented Sep 19, 2018

bors r=therealprof

bors bot added a commit that referenced this pull request Sep 19, 2018
114: 2018 edition r=therealprof a=japaric

This PR:

- moves the code to the 2018 edition and to cortex-m-rt v0.6.x
- simplifies setting up correct permissions (i.e. udev rules) for the st-link and the serial adapter 

closes #102 

r? @rust-embedded/resources (anyone)

Co-authored-by: Jorge Aparicio <jorge@japaric.io>
@bors
Copy link
Contributor

bors bot commented Sep 19, 2018

Build succeeded

@bors bors bot merged commit 1e9b885 into master Sep 19, 2018
@bors bors bot deleted the 2018 branch September 19, 2018 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port code snippets to the 2018 edition
3 participants