Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the crate to compile with newest nightly #33

Closed
wants to merge 1 commit into from

Conversation

bugadani
Copy link

The latest nightly removed the asm! syntax, which broke the ancient cortex-m this crate depends on. This PR updates the dependency and works around the fact that Mutex::lock was somewhere lost in history.

@bugadani bugadani requested a review from a team as a code owner May 30, 2020 08:02
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @korken89 (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@diondokter
Copy link

Oh whoops, I didn't even look to see if there already was a PR.
I made one too (#34), but mine uses refcell instead of unsafe. So I'm gonna leave mine up so the maintainers can decide which they rather have.

@jonas-schievink
Copy link
Contributor

Merged #26 instead, but thanks anyways!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants