-
Notifications
You must be signed in to change notification settings - Fork 187
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
80: replace uses of ! with Void r=japaric a=japaric We are soon going to push for embedded *library* development on beta (1.27-beta) to minimize the number of unstable features used in the ecosystem and ease the transition towards *application* development on stable (1.28 or 1.29). Unfortunately `!` didn't make it into the beta release but we still need to make this crate work on beta because a lot of crates depend on it. So this PR replaces the single use of the `!` type (cf. `CountDown.wait`) with the equivalent, but stable, `Void` type. This is a [breaking-change]. Implementations of the `CountDown` trait will have to update the signature of `wait` to return `nb::Result<(), Void>`. cc @therealprof @hannobraun I'm going to publish v0.2.0 *soon* (ideally tonight). If there's some **breaking**, but *uncontroversial*, change that should be included in it let me know ASAP so we can land it before the release. Co-authored-by: Jorge Aparicio <jorge@japaric.io>
- Loading branch information
Showing
8 changed files
with
86 additions
and
45 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
status = [ | ||
"continuous-integration/travis-ci/push", | ||
] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,9 @@ | ||
set -euxo pipefail | ||
|
||
main() { | ||
return | ||
if [ $TARGET != x86_64-unknown-linux-gnu ]; then | ||
rustup target add $TARGET | ||
fi | ||
} | ||
|
||
main |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters