Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

embedded-hal: digital: add #[inline] hints for PinState functions #463

Merged
merged 1 commit into from
May 31, 2023

Conversation

luojia65
Copy link
Contributor

@luojia65 luojia65 commented May 31, 2023

Add inline hints for:

  • <PinState as Not>::not
  • <PinState as From<bool>>::from
  • <bool as From<PinState>>::from

Those hints would allow further optimizations if PinState structure functions is used on embedded-hal projects.

Add inline hints for:

- <PinState as Not>::not
- <PinState as From<bool>>::from
- <bool as From<PinState>>::from

Those hints would allow further optimizations if PinState structure functions is used on embedded-hal projects.

Signed-off-by: Zhouqi Jiang <luojia@hust.edu.cn>
@luojia65 luojia65 requested a review from a team as a code owner May 31, 2023 12:18
Copy link
Member

@Dirbaio Dirbaio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

bors r+

@bors
Copy link
Contributor

bors bot commented May 31, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 7e24e0c into rust-embedded:master May 31, 2023
12 checks passed
@luojia65 luojia65 deleted the patch-1 branch July 8, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants