Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bus/spi: add semver risk warning to new_no_delay. #558

Merged
merged 1 commit into from
Dec 27, 2023
Merged

bus/spi: add semver risk warning to new_no_delay. #558

merged 1 commit into from
Dec 27, 2023

Conversation

Dirbaio
Copy link
Member

@Dirbaio Dirbaio commented Dec 27, 2023

Fixes #552.

@Dirbaio Dirbaio requested a review from a team as a code owner December 27, 2023 13:52
@Dirbaio Dirbaio mentioned this pull request Dec 27, 2023
Closed
eldruin
eldruin approved these changes Dec 27, 2023
View reviewed changes
Copy link
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me, thanks!

@eldruin eldruin added this pull request to the merge queue Dec 27, 2023
MabezDev
MabezDev approved these changes Dec 27, 2023
View reviewed changes
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Merged via the queue into rust-embedded:master with commit 94a7844 Dec 27, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eldruin eldruin eldruin approved these changes

@MabezDev MabezDev MabezDev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document SemVer hazards of spi::Operation::DelayNs
3 participants
@Dirbaio @eldruin @MabezDev