Implement Eq and PartialEq for Range and Permission #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsgf
force-pushed
the
pmpcfgx-eq
branch
2 times, most recently
from
40b9f24
to
8a789d2
Compare
romancardenas
requested changes
May 7, 2024
It's useful to be able to do equality tests for these for unit tests.
|
OK I rebased it over the check-cfg updates. |
facebook-github-bot
pushed a commit
to facebook/sapling
that referenced
this pull request
May 10, 2024
Summary: Bring in: - rust-embedded/riscv#206 - Eq for Permission - rust-embedded/riscv#207 - Mstatus update operations Details of 207 are still under discussion so this will probably need another freshen (and go back to pulling from the riscv repo once its landed). Reviewed By: dtolnay Differential Revision: D57136236 fbshipit-source-id: 09e5365d3fd499c4dccae7d2ada333bf369fac47
facebook-github-bot
pushed a commit
to facebookexperimental/rust-shed
that referenced
this pull request
May 10, 2024
Summary: Bring in: - rust-embedded/riscv#206 - Eq for Permission - rust-embedded/riscv#207 - Mstatus update operations Details of 207 are still under discussion so this will probably need another freshen (and go back to pulling from the riscv repo once its landed). Reviewed By: dtolnay Differential Revision: D57136236 fbshipit-source-id: 09e5365d3fd499c4dccae7d2ada333bf369fac47
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's useful to be able to do equality tests for these for unit tests.
Should we do this more consistently?