Several updates #67
Merged
Several updates #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ryankurte (or someone else) soon. Please see the contribution instructions for more information. |
|
bors try |
Closed
posborne
approved these changes
Sep 21, 2021
There was a problem hiding this comment.
Updates LGTM. I think one additional thing we could add that was requested elsewhere would be the specify features as part of package.metadata.docs.rs in order to include the tokio docs in what gets published to docs.rs.
|
Sounds good. I will add that in a separate PR, thanks! |
tryTimed out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use_tokiofeatureasync-tokiolike ingpio-cdev. (The word "use" is discouraged in feature names: C-FEATURE)Fixes #66