Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use svd-parser Index #631

Merged
merged 5 commits into from
Jul 23, 2022
Merged

use svd-parser Index #631

merged 5 commits into from
Jul 23, 2022

Conversation

burrbull
Copy link
Member

@burrbull burrbull commented Jul 17, 2022

Should fix #528 #610 #623 #625

@rust-highfive
Copy link

r? @Emilgardis

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools labels Jul 17, 2022
@burrbull burrbull force-pushed the index branch 3 times, most recently from ef12716 to 519c450 Compare July 19, 2022 11:43
@burrbull
Copy link
Member Author

cc @qwandor
Test this, please.

@burrbull burrbull marked this pull request as ready for review July 19, 2022 12:11
@burrbull burrbull requested a review from a team as a code owner July 19, 2022 12:11
@burrbull burrbull changed the title use svd-parser Index (experiment) use svd-parser Index Jul 19, 2022
@burrbull burrbull force-pushed the index branch 2 times, most recently from 7999dcc to 21db400 Compare July 19, 2022 15:39
@burrbull
Copy link
Member Author

This is not ideal as it still copies derived registers instead of using of reexport/alias, but it is task for other PR in my view.

@burrbull
Copy link
Member Author

cc @Emilgardis let's merge this

src/generate/peripheral.rs Outdated Show resolved Hide resolved
src/generate/peripheral.rs Outdated Show resolved Hide resolved
Copy link
Member

@Emilgardis Emilgardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

very nice

@bors
Copy link
Contributor

bors bot commented Jul 23, 2022

Build succeeded:

@qwandor
Copy link

qwandor commented Jul 25, 2022

@burrbull The resulting code builds, so that's promising. I haven't had a chance to do any more extensive tests yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support register derivation across peripherals
4 participants