-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix field derive in same register #628
Conversation
r? @therealprof (rust-highfive has picked a reviewer for you, use r? to override) |
сс @qwandor Can you make fixed link to SVDs to add them to CI? |
I'm not quite sure what you mean by that, what exactly do you want me to do? The SVD files in https://github.com/gd32-rust/gd32-rs are extensively patched with |
Just don't delete this file. |
if it's troublesome to host it, we can upload it as a gist if we're allowed |
Okay, I'll keep it up there for now, and let you know if anything changes. |
@qwandor There is still remains 16 broken fields with too complicate derive paths. I'm not sure I'm able to solve this without full rewrite of derive path resolving (#623). |
Is there an advantage of 0.23.1 over 0.24.0 here? |
No advantage, but 0.24.0 is broken and generates incorrect code in some cases. |
Close in favor of #631 |
Fixes #625