Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raw_access #841

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

raw_access #841

wants to merge 1 commit into from

Conversation

burrbull
Copy link
Member

@burrbull burrbull commented May 16, 2024

dependent on #842

cc @adamgreig

@adamgreig
Copy link
Member

I'm not sure if there's any advantage to skipping volatile_cell but still having the registers be themselves memory-mapped (with &self cast to a pointer). We still have the problem that Rust can dereference &self and perform an invalid read. Probably we have to do something similar to chiptool where the peripheral struct owns a pointer and the register methods offset it - the total memory cost is the same because instead of having reference-to-a-ZST like now, we would have an owned-pointer.

It might be hard to do this and keep vcell too, but maybe we can just remove vcell support at the same time?

@burrbull burrbull force-pushed the raw branch 2 times, most recently from 904b44e to a816243 Compare May 18, 2024 07:32
@burrbull burrbull changed the title raw_access && raw_read_write raw_access May 18, 2024
@burrbull
Copy link
Member Author

burrbull commented May 18, 2024

It might be hard to do this and keep vcell too, but maybe we can just remove vcell support at the same time?

It is not hard. svd2rust code is flexible enough.

Review yet one time, please.

P.S. Let's merge #842 first

@burrbull
Copy link
Member Author

burrbull commented Jun 4, 2024

/ci diff pr

Copy link

github-actions bot commented Jun 4, 2024

Diff for comment

@burrbull
Copy link
Member Author

burrbull commented Jun 4, 2024

/ci diff pr --current " --raw-access"

Copy link

github-actions bot commented Jun 4, 2024

Diff for comment

@burrbull burrbull marked this pull request as ready for review June 4, 2024 03:12
@burrbull burrbull requested a review from a team as a code owner June 4, 2024 03:12
@burrbull
Copy link
Member Author

burrbull commented Jun 4, 2024

/ci diff pr

Copy link

github-actions bot commented Jun 4, 2024

Diff for comment

@burrbull
Copy link
Member Author

burrbull commented Jun 4, 2024

/ci diff pr --current " --raw-access"

Copy link

github-actions bot commented Jun 4, 2024

Diff for comment

@burrbull
Copy link
Member Author

burrbull commented Jun 9, 2024

rebased on #847

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants