Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support memory copying instruction (EIP-5656) #279

Merged

Conversation

Agusrodri
Copy link
Contributor

@Agusrodri Agusrodri commented May 6, 2024

This PR adds an adaptation to EIP-5656 which introduces the MCOPY opcode.

By using this new instruction, it is possible to copy parts of the memory in a cheaper and easier way, everything done with one opcode.

Note

All the Cancun ethereum-tests related to MCOPY pass with this implementation.

@RomarQ
Copy link
Contributor

RomarQ commented May 13, 2024

We could add a new flag eip_5656_enabled to the config for reverting when MCOPY is used in forks that should not support it.

Similar change for eip-1153 b8bfe59

@Agusrodri
Copy link
Contributor Author

We could add a new flag eip_5656_enabled to the config for reverting when MCOPY is used in forks that should not support it.

Similar change for eip-1153 b8bfe59

Done in 3f15f92 :)

@koushiro koushiro requested a review from sorpaas May 19, 2024 08:32
@koushiro
Copy link
Contributor

koushiro commented Jun 3, 2024

@Agusrodri please resolve the conflicts

@RomarQ
Copy link
Contributor

RomarQ commented Jun 4, 2024

@Agusrodri please resolve the conflicts

Done 👍

Co-authored-by: Qinxuan Chen <koushiro.cqx@gmail.com>
@koushiro koushiro merged commit e5802fb into rust-ethereum:master Jun 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants