Add option to kill afl-fuzz after a time limit #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frewsxcv
approved these changes
Jan 22, 2020
* Removes ArgRequiredElseHelp, as it is redundant with SubcommandRequiredElseHelp. (Subcommands count as arguments for the purposes of ArgRequiredElseHelp.) * Removes TrailingVarArg from the afl subcommand, because extra arguments are already handled by its subcommands with AllowLeadingHyphen and a .multiple(true) argument, or by AllowExternalSubcommands. * Updates clap to 0.33 to pick up DisableHelpFlags * Uses DisableHelpFlags in subcommands rather than defining hidden "h" and "help" arguments.
|
hey @divergentdave, feel free to merge + release whenever this is done! i don't have much bandwidth to maintain afl.rs nowadays |
|
Will do, I'm pretty happy with it at this point |
|
Whoops, actually it looks like I don't have write access, either in this repository or rust-fuzz/targets |
|
How about now? |
|
Got it, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new option to
cargo afl fuzz,--max_total_time, to limit how long afl-fuzz runs for. The new option will enable implementing rust-fuzz/targets#107. When this option is specified,cargo-aflwill wait that many seconds and killafl-fuzz, if it's still running. I had to refactor how command line arguments were passed around, as well, so that this new option didn't get passed toafl.