build.rs: Remove DEBUG environment variable to prevent spurious build… #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you very much for this analysis. Could we make it that |
|
Sure! I've force-pushed a change to that effect and also rebased onto the latest master. |
smoelius
reviewed
Aug 30, 2022
The DEBUG variable is only removed it set to `false` by cargo. When called with DEBUG set, AFLplusplus will set -Werror in CFLAGS and sometimes fail to build spuriously.
|
Thanks a bunch! |
This was referenced Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #202.
When running
build.rs, cargo sets theDEBUGenvironment variable totrueorfalsedepending on the build mode. However, the AFLplusplus makefiles only check ifDEBUGis set or not. Hence, in either case, AFLplusplus will build in debug mode and append-WerrortoCFLAGS.