New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Faster defaults #231
Faster defaults #231
Conversation
Tests are failing because they look for bins at the Also, please add a test for the |
2054082
to
3c5d57f
Compare
I've fixed everything as requested. Will add a test for Do you have any ideas on how to clearly document that the default is Also, there are two changes that might be unexpected for end users:
Should we document this somewhere? |
Should be good to go now. Please take another look. |
I'm personally not too concerned with either of these, but we can bump to 0.8.x to be safe. @Manishearth any opinion here?
Perhaps in the before-help blurb for Lines 36 to 43 in 87c36a1
And I think we would also want a custom template for Line 107 in 87c36a1
This way we could include the same blurb for both subcommands's help messages. |
There's not really a good reason to not bump a "breaking" version number for binaries once there are larger changes to the interface. I vote bump. |
…` help text. Also mention sanitizers in `cargo fuzz build` help text
I've added a blurb about default build flags to the help text of both |
@fitzgen I don't consider these to require a new major version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks @Shnatsel!
@@ -68,6 +72,17 @@ include: | |||
http://llvm.org/docs/LibFuzzer.html#dictionaries\ | |||
"; | |||
|
|||
const BUILD_BEFORE_HELP: &'static str = "\ | |||
By default fuzz targets are built with optimizations equivalent to | |||
`cargo build --release`, but with debug assertions and overflow checks enabled. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but with debug assertions and overflow checks enabled
which code in this pr is responsible for enabling debug assertions with release mode by default?
Add command line option for controlling overflow checksResolves #230