-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix minor build.rs issues w.r.t. custom libfuzzer paths #103
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Wow, that was fast! 😁 |
Heh no problem. Looks like this needs a |
Yup, was editing in a simple text editor while I was working with something. Should be good now. |
@@ -1,10 +1,13 @@ | |||
fn main() { | |||
println!("cargo:rerun-if-env-changed=CUSTOM_LIBFUZZER_PATH"); | |||
if let Ok(custom) = ::std::env::var("CUSTOM_LIBFUZZER_PATH") { | |||
let custom_lib_path = ::std::path::PathBuf::from(&custom); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding a println!("cargo:rerun-if-changed={custom}");
here might be useful :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair point -- added!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Makes libfuzzer_sys rebuild if the custom libfuzzer path changes and use the correct lib name if the library is double-prefixed ("liblib").