Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experiment with a special "archive" category #485

Closed
ozkriff opened this issue May 17, 2022 · 4 comments
Closed

Experiment with a special "archive" category #485

ozkriff opened this issue May 17, 2022 · 4 comments
Assignees

Comments

@ozkriff
Copy link
Member

ozkriff commented May 17, 2022

See #483

I'll try to make the initial prototype in a week or so (i'm terrible at time estimations though).

Related to #95
Related to #320

@ozkriff
Copy link
Member Author

ozkriff commented Jul 3, 2023

I'm against removing even more stuff from the database, I'd much prefer the archived category to be implemented - #485 - though I wasn't able to really work on this yet and won't be in the next couple of weeks. If anyone feels that the need to clean up AWGY is urgent, please feel free to propose PRs that introduce the "archived" category.

So yeah, if anyone wants to work on this now, feel free to propose PRs.

@17cupsofcoffee
Copy link
Collaborator

I finally have a bit of free time now, so I had a go at mocking something up for an 'archive' section:

image

I chose to add it to the existing category pages rather than creating new ones for the sake of simplicity.

Couple of other tweaks I considered:

  • Rather than having a seperate section, we could just grey them out and sort to the bottom of the list, but not sure whether that would make it clear enough.
    • I could also grey/red them out even with the layout shown above, just to make them a little more visually distinct.
  • It could be worth us disabling Crates.io/GitHub data fetching for archived crates, to speed up the build a little.
  • Not sure if the bed icon makes sense, but I couldn't find a more fitting one 😆

Any thoughts on this?

@ozkriff
Copy link
Member Author

ozkriff commented Sep 12, 2023

@17cupsofcoffee (sorry for the late reply!)

I chose to add it to the existing category pages rather than creating new ones for the sake of simplicity.

yeah, it sounds great to me! and I agree that it's worth graying them out anyway too.

It could be worth us disabling Crates.io/GitHub data fetching for archived crates, to speed up the build a little.

most of the libraries don't have a description in our data.toml so if we disable data fetching only a name would left. i'd prefer to keep data fetching for them, at least for now.

Not sure if the bed icon makes sense, but I couldn't find a more fitting one 😆

I agree that it's probably not perfect but I too can't find a better icon quickly so let's keep the bed icon for now - we can always change it later.

So please open a PR! 🙏

@17cupsofcoffee
Copy link
Collaborator

Added in #546.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants