Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

N15: Arsenal #318

Closed
wants to merge 1 commit into from
Closed

N15: Arsenal #318

wants to merge 1 commit into from

Conversation

zicklag
Copy link
Contributor

@zicklag zicklag commented Oct 31, 2020 •
edited by ozkriff

If the logo is to tall I can create a thinner version of it or something. Up to you. 馃檪

Edit: Nevermind, changed the logo to a thin one.

Part of #320 ("Newsletter 15")

@zicklag zicklag force-pushed the arsenal-development branch 2 times, most recently from 4c41e76 to 7a412e1 Compare October 31, 2020 21:04
@ozkriff ozkriff changed the title Add Arsenal Development N15: Arsenal Nov 1, 2020
@ozkriff ozkriff mentioned this pull request Nov 2, 2020
Closed
54 tasks
17cupsofcoffee
17cupsofcoffee approved these changes Nov 2, 2020
View reviewed changes
Copy link
Collaborator

@17cupsofcoffee 17cupsofcoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ozkriff pushed a commit that referenced this pull request Nov 4, 2020
@zicklag @ozkriff
N15: Arsenal (#318)
17f3973
ozkriff
ozkriff approved these changes Nov 4, 2020
View reviewed changes
Copy link
Member

@ozkriff ozkriff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃憤 but needs a few style tweaks

@ozkriff
Copy link
Member

ozkriff commented Nov 4, 2020

CONTRIBUTING.md:

Make sure that the "Allow edits from maintainers" box is checked (avoid using org accounts if possible) - it makes updating/tweaking the PR easier for the coordinators.

Updated and merged manually in 17f3973

Thanks for the PR!

@ozkriff ozkriff closed this Nov 4, 2020
@zicklag
Copy link
Contributor Author

zicklag commented Nov 4, 2020 •
edited

Make sure that the "Allow edits from maintainers" box is checked (avoid using org accounts if possible) - it makes updating/tweaking the PR easier for the coordinators.

Ah, sorry 'bout that. I thought that was checked by default usually.

Edit: Oh, I get it now, that's what the Org account doesn't let you do. 馃憤

Thanks for the PR!

Thanks for the newsletter! 馃檪

@zicklag zicklag deleted the arsenal-development branch November 4, 2020 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ozkriff ozkriff ozkriff approved these changes

@17cupsofcoffee 17cupsofcoffee 17cupsofcoffee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zicklag @ozkriff @17cupsofcoffee